Bug 243624

Summary:	Style checking still warns about SVN auto props
Product:	WebKit	Reporter:	Nikolas Zimmermann <zimmermann>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED DUPLICATE
Severity:	Normal	CC:	aakash_jain, jbedard, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Local Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	239082

Nikolas Zimmermann

Reported 2022-08-06 01:33:37 PDT

I've tried to create an upstream branch using "git-webkit pr" that added hundreds of new pixel test results. This highlighted a problem: Style checking wants me to enable auto props in the SVN config file -- that is not necessary anymore, and the rule could be disabled, no? $ git webkit pr ... Current branch eng/macOS-Check-in-remaining-pixel-test-results-to-assist-LBSE-development is up to date. Found 1 commit... ERROR: LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:0: Have to enable auto props in the subversion config file (/Users/nzimmermann/.subversion/config "enable-auto-props = yes"). [image/png] [5] Total errors found: 1 in 1 files style-checker failed, continue uploading pull request? (Yes/[No]): yes Enumerating objects: 1143, done. Counting objects: 100% (1143/1143), done. ...

Attachments
Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2022-08-10 13:01:18 PDT

Yes, the check should be deleted.

Radar WebKit Bug Importer

Comment 2 2022-08-13 01:34:34 PDT

<rdar://problem/98607937>

Jonathan Bedard

Comment 3 2023-05-01 17:00:29 PDT

*** This bug has been marked as a duplicate of bug 253386 ***

Note You need to log in before you can comment on or make changes to this bug.