Bug 24353

Summary:

Allow to overrule default build options for Qt build

Product:

WebKit

Reporter:

Laszlo Gombos <laszlo.gombos>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hausmann, vestbo

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
Proposed fix to make the Qt build system more flexible and consistent	staikos: review+

Description Laszlo Gombos 2009-03-04 07:21:19 PST

WebKit in general, and the Qt port specifically does a good job of picking sensible default configuration options and at the same time allowing the build system to overrule the default options without changing the source code.

I run into a few configuration options where the Qt build system does not allow to overrule the defaults. For example WebCore.pro makes a choice that if "embedded" is defined than NETSCAPE_PLUGIN_API is not supported; and this choice can not be overruled without changing WebCore.pro.

A patch will follow to address this issue and make the Qt build system more flexible and consistent to follow a general guideline that if a default config coice is made than there should be a way to overrule the default config choice without changing the source files.

Comment 1 Laszlo Gombos 2009-03-04 07:27:18 PST

Created attachment 28265 [details]
Proposed fix to make the Qt build system more flexible and consistent

Comment 2 Adam Treat 2009-03-09 09:38:16 PDT

Landed with r41528.