Bug 243430
| Summary: | [WPE][GTK] Incremental build fixes for PDF.js | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | Assignee: | Michael Catanzaro <mcatanzaro> | |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | thorton, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | PC | ||
| OS: | Linux | ||
Michael Catanzaro
Some incremental build fixes for PDF.js:
(1) PdfJSExtraFiles includes only the cross-platform files. If platform-specific files are modified, they won't be rebuilt.
(2) The command that compiles the PdfJSGResourceBundleExtras resource manifest should depend on the depfile it generates, so it gets rebuilt if any of the files change. The main PdfJSGResourceBundle already does this, as do all our other gresources. It's confusing for a command to depend on a file that it generates itself, but the alternative is no dependency tracking at all.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
Pull request: https://github.com/WebKit/WebKit/pull/2923
EWS
Committed 253195@main (d0e360af8478): <https://commits.webkit.org/253195@main>
Reviewed commits have been landed. Closing PR #2923 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/98287607>