Bug 243316

Summary: check-webkit-style: Suppress runtime/wtf_move and runtime/wtf_make_unique for MiniBrowsers
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: Tools / TestsAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: b7r.mmxxx, basuke, darin, don.olmstead, ews-watchlist, glenn, jbedard, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
[fast-cq] Patch for landing none

Fujii Hironori
Reported 2022-07-28 14:20:57 PDT
check-webkit-style: Suppress runtime/wtf_move and runtime/wtf_make_unique for Windows and PlayStation MiniBrowsers > ERROR: Tools/MiniBrowser/playstation/MainWindow.cpp:144: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] > ERROR: Tools/MiniBrowser/playstation/WebViewWindow.cpp:68: Use 'WTF::makeUnique<WebViewWindow>' instead of 'std::make_unique<WebViewWindow>'. [runtime/wtf_make_unique] [4] Windows and PlayStation MiniBrowsers don't use WTF, try to use only public WebKit API.
Attachments
Patch (1.27 KB, patch)
2022-07-28 14:23 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
[fast-cq] Patch for landing (1.19 KB, patch)
2022-07-28 17:20 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2022-07-28 14:23:07 PDT
Created attachment 461280 [details] Patch
Darin Adler
Comment 2 2022-07-28 15:32:10 PDT
Comment on attachment 461280 [details] Patch OK, but I think we probably want to do this for MiniBrowser on all platforms. I suspect the reason it doesn’t come up with the Apple platform MiniBrowser versions is that they are not written in C++.
Fujii Hironori
Comment 3 2022-07-28 17:05:26 PDT
Thank you for the review. It's a good point. mac, gtk, and wpe MiniBrowser also isn't using WTF. Will fix.
Fujii Hironori
Comment 4 2022-07-28 17:20:19 PDT
Created attachment 461285 [details] [fast-cq] Patch for landing
EWS
Comment 5 2022-07-28 17:22:28 PDT
Committed 252932@main (f156890e65f5): <https://commits.webkit.org/252932@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461285 [details].
Radar WebKit Bug Importer
Comment 6 2022-07-28 17:23:15 PDT
<rdar://problem/97752777>
Note You need to log in before you can comment on or make changes to this bug.