Bug 24331

Summary:

Add custom V8 bindings for Element, Attr, HTMLFrame, and HTMLIFrame

Product:

WebKit

Reporter:

Dimitri Glazkov (Google) <dglazkov>

Component:

WebCore Misc.

Assignee:

Dimitri Glazkov (Google) <dglazkov>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Add custom V8 bindings for Element, Attr, HTMLFrame, and HTMLIFrame, v1	eric: review+

Dimitri Glazkov (Google)

Reported 2009-03-03 10:51:57 PST

Rietveld is deathly ill today, so we'll go straight to the source...

Attachments
Add custom V8 bindings for Element, Attr, HTMLFrame, and HTMLIFrame, v1 (17.41 KB, patch) 2009-03-03 10:54 PST, Dimitri Glazkov (Google)	eric: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dimitri Glazkov (Google)

Comment 1 2009-03-03 10:54:27 PST

Created attachment 28230 [details] Add custom V8 bindings for Element, Attr, HTMLFrame, and HTMLIFrame, v1 WebCore/ChangeLog | 14 ++ WebCore/bindings/v8/custom/V8AttrCustom.cpp | 58 +++++++ WebCore/bindings/v8/custom/V8CustomBinding.cpp | 59 +++++++ WebCore/bindings/v8/custom/V8CustomBinding.h | 11 ++ WebCore/bindings/v8/custom/V8ElementCustom.cpp | 169 ++++++++++++++++++++ .../v8/custom/V8HTMLFrameElementCustom.cpp | 62 +++++++ .../v8/custom/V8HTMLIFrameElementCustom.cpp | 51 ++++++ 7 files changed, 424 insertions(+), 0 deletions(-)

Eric Seidel (no email)

Comment 2 2009-03-03 11:11:49 PST

Comment on attachment 28230 [details] Add custom V8 bindings for Element, Attr, HTMLFrame, and HTMLIFrame, v1 Looks fine. I would have put toEventType closer to where it's used in the file. I don't think we have any rule about statics being at the top or anything (maybe we should?)

Dimitri Glazkov (Google)

Comment 3 2009-03-03 11:19:50 PST

Landed (after moving toEventType down to event handler code) as http://trac.webkit.org/changeset/41399.

Note You need to log in before you can comment on or make changes to this bug.