Bug 243286 – AX: AccessibilityObject::accessibilityVisibleCharacterRange misses the first line of a paragraph split across pages (part two)

• Component: Accessibility
• Status: RESOLVED FIXED

[Tyler Wilcock]

In https://bugs.webkit.org/show_bug.cgi?id=242880, we made a change that prevented this issue in some (in reality, only a few) cases. However, after further testing, I've found other cases that are not fixed.

[Radar WebKit Bug Importer]

<rdar://problem/97706360>

[Tyler Wilcock]

Created attachment 461266 [details]
Patch

[chris fleizach]

Comment on attachment 461266 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461266&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:845
> +        float lastX = elementRect.x();

do we want the MaxX here of the rect rather than the origin?

[Tyler Wilcock]

(In reply to chris fleizach from comment #3)
> Comment on attachment 461266 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=461266&action=review
> 
> > Source/WebCore/accessibility/AccessibilityObject.cpp:845
> > +        float lastX = elementRect.x();
> 
> do we want the MaxX here of the rect rather than the origin?

I don't think so as maxX includes width, which we expect to not be consistent (because paragraphs will extend different lengths down the line). So it wouldn't be a good indicator that we've crossed a viewport boundary.

[EWS]

Committed 252920@main (f59072f13d29): <https://commits.webkit.org/252920@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461266 [details].