Bug 243053

Summary: Import css/css-sizing/aspect-ratio tests from WPT
Product: WebKit Reporter: Rob Buis <rbuis>
Component: CSSAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, ews-watchlist, ntim, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Safari 15   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Rob Buis
Reported 2022-07-21 07:11:23 PDT
Import css/css-sizing/aspect-ratio tests from WPT.
Attachments
Patch (62.03 KB, patch)
2022-07-21 07:14 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (62.37 KB, patch)
2022-07-21 09:33 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2022-07-21 07:14:56 PDT
Created attachment 461114 [details] Patch
Tim Nguyen (:ntim)
Comment 2 2022-07-21 08:54:20 PDT
r=me if EWS is happy
Tim Nguyen (:ntim)
Comment 3 2022-07-21 08:55:35 PDT
Comment on attachment 461114 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=461114&action=review > LayoutTests/TestExpectations:4609 > # contain-intrinsic-size Is this the correct category?
Rob Buis
Comment 4 2022-07-21 09:31:30 PDT
Comment on attachment 461114 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=461114&action=review >> LayoutTests/TestExpectations:4609 >> # contain-intrinsic-size > > Is this the correct category? This section is a bit unstructured. The comment was made in the spirit of, if we support contain-intrinsic-size we will pass most of these aspect-ratio tests listed here (but not all since some do not use contain-intrinsic-size). As you can see the next block is actual contain-intrinsic-size directory. I'll update this before landing.
Rob Buis
Comment 5 2022-07-21 09:33:57 PDT
Created attachment 461116 [details] Patch
EWS
Comment 6 2022-07-21 14:17:47 PDT
Committed 252707@main (806774691444): <https://commits.webkit.org/252707@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461116 [details].
Radar WebKit Bug Importer
Comment 7 2022-07-21 14:18:17 PDT
<rdar://problem/97399497>
Note You need to log in before you can comment on or make changes to this bug.