Bug 242842
| Summary: | There should be a way to indicate that PR should not close a bug | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | aakash_jain, ap, fujii.hironori, jbedard, ryanhaddad, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 239082 | ||
Ryosuke Niwa
When landing test expectation changes, etc... in GitHub, there should be a label to indicate that
merge-queue / unsafe-merge-queue should not close the Bugzilla bug.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
I think that such mechanism exists and is used by bot watchers, but I don't know what it is.
Fujii Hironori
See Bug#239604
Ryosuke Niwa
lol, it looks for the substring "Unreviewed test gardening":
https://github.com/WebKit/WebKit/commit/253a62f8ead480bd1f0683cace622b2ebc1231cd
Alexey Proskuryakov
Is this just a dupe of bug 239604 at this point, or are you looking for a different solution?
Ryosuke Niwa
(In reply to Alexey Proskuryakov from comment #4)
> Is this just a dupe of bug 239604 at this point, or are you looking for a
> different solution?
I don't think special casing test gardening makes sense. We need the equivalent of --no-close for git-webkit.
Radar WebKit Bug Importer
<rdar://problem/97502232>