Bug 242833
| Summary: | [LBSE] Enable compositing support for SVG elements | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> |
| Component: | SVG | Assignee: | Nikolas Zimmermann <zimmermann> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | fujii.hironori, rbuis, sabouhallawa, simon.fraser, webkit-bug-importer, zimmermann |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 241762 | ||
| Bug Blocks: | 27684, 90738, 243417 | ||
Nikolas Zimmermann
Finally enable compositing, 3d-transforms, etc. for SVG.
All the preparatory work is done and LBSE has enough functionality to support it.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Nikolas Zimmermann
Pull request: https://github.com/WebKit/WebKit/pull/2487
Radar WebKit Bug Importer
<rdar://problem/97481962>
EWS
Committed 253054@main (5c46074bb656): <https://commits.webkit.org/253054@main>
Reviewed commits have been landed. Closing PR #2487 and removing active labels.
Fujii Hironori
Hi, I tested 253054@main. But, your tiger doesn't animate. Is this expected? https://ibb.co/mcSnFZP
Nikolas Zimmermann
(In reply to Fujii Hironori from comment #4)
> Hi, I tested 253054@main. But, your tiger doesn't animate. Is this expected?
> https://ibb.co/mcSnFZP
Thanks Fujji for the early testing. Yes it is expected -- there's still stuff missing to make the demos work. I will let you know when you can repeat the testing :-)
Nikolas Zimmermann
(In reply to Nikolas Zimmermann from comment #5)
> (In reply to Fujii Hironori from comment #4)
> > Hi, I tested 253054@main. But, your tiger doesn't animate. Is this expected?
> > https://ibb.co/mcSnFZP
> Thanks Fujji for the early testing. Yes it is expected -- there's still
> stuff missing to make the demos work. I will let you know when you can
> repeat the testing :-)
Oh, I mixed this up, thought you were talking about the vibrant tiger example. The one from 2019 in the reveal.js presentation should work -- did you click on "Welcome to the future" to trigger the animation?
NOTE: You'll notice that the tiger SVG is clipped -- that's a bug in the actual html/svg file, due to missing viewport clipping in earlier LBSE versions. To see the unclipped tiger, you need to manually enlarge the viewport in the svg document fragment.
Fujii Hironori
Oh, I didn't click. It works! You did a great job!
Nikolas Zimmermann
(In reply to Fujii Hironori from comment #7)
> Oh, I didn't click. It works! You did a great job!
Thanks Fujii, still LBSE is not ready yet for production. I will soon create GitHub issues on https://github.com/nikolaszimmermann/WebKitIgalia/issues, to track what's still missing in LBSE -- better than tickin' off items on my personal, invisible TODO list :-)