Bug 242735

Summary:

Commit queue fails to land patch with changes to prepare-ChangeLog script

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, jbedard, webkit-bug-importer, youssefdevelops

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

237581, 246323

Attachments:

Description	Flags
Patch without test for EWS	none
Patch v2	none
Patch v3	jbedard: review+, ddkilzer: commit-queue-
Patch for landing	none

David Kilzer (:ddkilzer)

Reported 2022-07-13 20:13:06 PDT

Commit queue fails to land patch with changes to prepare-ChangeLog script. See Bug 237581, Attachment 460877 [details]: <https://bugs.webkit.org/show_bug.cgi?id=237581> Specifically this failure: <https://ews-build.webkit.org/#/builders/28/builds/22797>

Attachments
Patch without test for EWS (1.69 KB, patch) 2022-07-14 09:16 PDT, David Kilzer (:ddkilzer)	no flags	Details Formatted Diff Diff
Patch v2 (16.79 KB, patch) 2022-07-15 14:08 PDT, David Kilzer (:ddkilzer)	no flags	Details Formatted Diff Diff
Patch v3 (16.82 KB, patch) 2022-07-15 14:38 PDT, David Kilzer (:ddkilzer)	jbedard: review+ ddkilzer: commit-queue-	Details Formatted Diff Diff
Patch for landing (16.88 KB, patch) 2022-07-15 16:57 PDT, David Kilzer (:ddkilzer)	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

David Kilzer (:ddkilzer)

Comment 1 2022-07-14 09:16:51 PDT

Created attachment 460893 [details] Patch without test for EWS

David Kilzer (:ddkilzer)

Comment 2 2022-07-15 14:08:18 PDT

Created attachment 460934 [details] Patch v2 Added test for the fix. Also refactored existing tests to pull out common code.

David Kilzer (:ddkilzer)

Comment 3 2022-07-15 14:38:37 PDT

Created attachment 460935 [details] Patch v3

David Kilzer (:ddkilzer)

Comment 4 2022-07-15 14:42:46 PDT

Comment on attachment 460935 [details] Patch v3 New test passes! Now up for review.

David Kilzer (:ddkilzer)

Comment 5 2022-07-15 14:49:45 PDT

Comment on attachment 460935 [details] Patch v3 Adding cq+ since all "services" tests passed. I don't think this change even affects any other tests until it's deployed.

David Kilzer (:ddkilzer)

Comment 6 2022-07-15 16:57:09 PDT

Created attachment 460944 [details] Patch for landing

David Kilzer (:ddkilzer)

Comment 7 2022-07-15 16:57:57 PDT

Comment on attachment 460944 [details] Patch for landing Tweaked the commit log message--not sure why these comments got lost.

EWS

Comment 8 2022-07-15 19:19:49 PDT

Committed 252532@main (97dcaeae0581): <https://commits.webkit.org/252532@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460944 [details].

Radar WebKit Bug Importer

Comment 9 2022-07-15 19:20:19 PDT

<rdar://problem/97106200>

David Kilzer (:ddkilzer)

Comment 10 2022-07-16 09:44:39 PDT

This patch left the commit queue bubble in a weird state--the patch landed, but commit queue thought it didn't?! Oh well.

Jonathan Bedard

Comment 11 2022-07-18 11:32:10 PDT

Re-opening for pull request https://github.com/WebKit/WebKit/pull/2515

EWS

Comment 12 2022-07-18 11:39:13 PDT

Committed 252571@main (da71edd76bae): <https://commits.webkit.org/252571@main> Reviewed commits have been landed. Closing PR #2515 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.