Bug 242719
| Summary: | Add push subscriptions to apsd ignore list if necessary | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ben Nham <nham> |
| Component: | WebKit Misc. | Assignee: | Ben Nham <nham> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | nham, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ben Nham
Currently, if a user changes the notification permission for an origin from Allow to Deny in the browser settings pane, we don't communicate this change to apsd. This means that pushes from this origin can continue to wake the device and induce battery drain even though the push will always be useless, as we bail out of running push event handlers early when we detect that an origin is missing the notification permission. We should fix this by adding topics associated with denied permissions to the apsd ignore list.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ben Nham
<rdar://problem/91586206>
Ben Nham
Pull request: https://github.com/WebKit/WebKit/pull/2384
EWS
Committed 252434@main (94e15b227a3c): <https://commits.webkit.org/252434@main>
Reviewed commits have been landed. Closing PR #2384 and removing active labels.