Bug 242270
| Summary: | REGRESSION (March 2022): [ iOS Debug ] fast/encoding/char-after-fast-path-ascii-decoding.html is a flaky failure | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Karl Rackler <rackler> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | CLOSED FIXED | ||
| Severity: | Normal | CC: | ap, darin, j_stfleur, sabouhallawa, webkit-bot-watchers-bugzilla, webkit-bug-importer |
| Priority: | P2 | Keywords: | EasyFix, GoodFirstBug, InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Karl Rackler
Description:
fast/encoding/char-after-fast-path-ascii-decoding.html
The first failure that I saw on the dashboard was on 4/2/2022 at 249160@main. This test has been flaky for its entire history on the dashboard.
History:
https://results.webkit.org/?suite=layout-tests&test=fast%2Fencoding%2Fchar-after-fast-path-ascii-decoding.html&platform=ios&limit=50000&style=debug
Diff:
--- /Volumes/Data/worker/ios-simulator-15-debug-tests-wk2/build/layout-test-results/fast/encoding/char-after-fast-path-ascii-decoding-expected.txt
+++ /Volumes/Data/worker/ios-simulator-15-debug-tests-wk2/build/layout-test-results/fast/encoding/char-after-fast-path-ascii-decoding-actual.txt
@@ -1,2 +1,2 @@
-ABCDEFGH‚‚
+
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/96316372>
Karl Rackler
I have marked this test as a flaky failure while this issue is investigated.
EWS
Test gardening commit 252073@main (68c924e054f4): <https://commits.webkit.org/252073@main>
Reviewed commits have been landed. Closing PR #2013 and removing active labels.
Alexey Proskuryakov
The test fails more frequently than it passes. It became dramatically more flaky a few months ago, in early March 2022.
Looking at the test, it incorrectly assumes that waiting for 500 ms guarantees that a subframe would be loaded. Why didn't we just use onload here? Also, the test doesn't need waitUntilDone/notifyDone, as tests complete after the load event by default.
A more interesting question that we will probably will never be able to answer is why loading a data: iframe takes more than half a second in this scenario.
EWS
Test gardening commit 290429@main (8c89679ad434): <https://commits.webkit.org/290429@main>
Reviewed commits have been landed. Closing PR #40649 and removing active labels.
Jay Stfleur
Closing this since test is passing
Alexey Proskuryakov
We still need to remove the test expectation in this case:
LayoutTests/platform/ios/TestExpectations:3733:webkit.org/b/242270 fast/encoding/char-after-fast-path-ascii-decoding.html [ Pass Failure ]
Darin Adler
So we should not have closed this I guess.