Bug 242178
| Summary: | REGRESSION (250816@main): composite option in Element.animate() is ignored | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> |
| Component: | Animations | Assignee: | Antoine Quint <graouts> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dino, graouts, gsnedders, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Antoine Quint
We used to guard the `iterationComposite` property with the same runtime flag as the `composite` property. When we introduced a dedicated flag for the iterationComposite property (bug 240727) we mistakenly switched the guard in `KeyframeEffect::create()` which governed both properties from the `composite` guard to the `iterationComposite` guard, instead of adding the two guards, one for each property. As a result, the `composite` property can no longer be set via Element.animate() or the KeyframeEffect constructor.
This was found by WPT.fyi with the recent release of STP 148 which first introduced this change:
https://wpt.fyi/results/web-animations/animation-model/animation-types/accumulation-per-property-001.html?q=seq%28%28status%3Apass%7Cstatus%3Aok%29%20%28status%3Apass%7Cstatus%3Aok%29%20%28status%3A%21pass%26status%3A%21ok%26status%3A%21unknown%29%20%28status%3A%21pass%26status%3A%21ok%26status%3A%21unknown%29%29&run_id=6308426865967104&run_id=5702899928662016&run_id=5636710942638080&run_id=5070812443836416
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Antoine Quint
Pull request: https://github.com/WebKit/WebKit/pull/1943
Radar WebKit Bug Importer
<rdar://problem/96211493>
EWS
Committed 251998@main (4fa06c18977a): <https://commits.webkit.org/251998@main>
Reviewed commits have been landed. Closing PR #1943 and removing active labels.