Bug 24212

Summary: Crashes when given the URI of a directory, or other non-regular files
Product: WebKit Reporter: Gustavo Noronha (kov) <gustavo>
Component: WebKitGTKAssignee: Gustavo Noronha (kov) <gustavo>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Gtk
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed fix
zecke: review+
errors cleanup zecke: review+

Gustavo Noronha (kov)
Reported 2009-02-26 15:39:14 PST
The crash happens because in this specific case an error is reported, but the GError that is given to networkErrorForFile is NULL, and error->message is accessed unconditionally.
Attachments
proposed fix (1.92 KB, patch)
2009-02-26 15:40 PST, Gustavo Noronha (kov) 		zecke: review+
DetailsFormatted DiffDiff
errors cleanup (3.73 KB, patch)
2009-03-01 07:51 PST, Gustavo Noronha (kov) 		zecke: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1 2009-02-26 15:40:13 PST
Created attachment 28049 [details] proposed fix
Holger Freyther
Comment 2 2009-03-01 07:26:50 PST
Comment on attachment 28049 [details] proposed fix Yeah. we leak the GError in the caller though.
Gustavo Noronha (kov)
Comment 3 2009-03-01 07:51:35 PST
Created attachment 28143 [details] errors cleanup
Holger Freyther
Comment 4 2009-03-01 08:12:19 PST
Comment on attachment 28143 [details] errors cleanup looks good, please split it in two parts.
Gustavo Noronha (kov)
Comment 5 2009-03-01 08:22:24 PST
Landed as r41332 and r41333.
Note You need to log in before you can comment on or make changes to this bug.