Bug 24208

Summary:

Add custom V8 bindings for Navigator, Clipboard, Document, and Node

Product:

WebKit

Reporter:

Dimitri Glazkov (Google) <dglazkov>

Component:

WebCore Misc.

Assignee:

Dimitri Glazkov (Google) <dglazkov>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Add custom V8 bindings for Navigator, Clipboard, Document, and Node, v1.	eric: review-
Add custom V8 bindings for Navigator, Clipboard, Document, and Node, v2.	eric: review+

Dimitri Glazkov (Google)

Reported 2009-02-26 14:48:54 PST

Pre-scrubbed here: http://codereview.chromium.org/27217

Attachments
Add custom V8 bindings for Navigator, Clipboard, Document, and Node, v1. (15.24 KB, patch) 2009-02-26 14:50 PST, Dimitri Glazkov (Google)	eric: review-	Details Formatted Diff Diff
Add custom V8 bindings for Navigator, Clipboard, Document, and Node, v2. (15.24 KB, patch) 2009-02-26 15:05 PST, Dimitri Glazkov (Google)	eric: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Dimitri Glazkov (Google)

Comment 1 2009-02-26 14:50:11 PST

Created attachment 28040 [details] Add custom V8 bindings for Navigator, Clipboard, Document, and Node, v1. WebCore/ChangeLog | 17 +++ WebCore/bindings/v8/custom/V8ClipboardCustom.cpp | 141 ++++++++++++++++++++++ WebCore/bindings/v8/custom/V8DocumentCustom.cpp | 86 +++++++++++++ WebCore/bindings/v8/custom/V8NavigatorCustom.cpp | 48 ++++++++ WebCore/bindings/v8/custom/V8NodeCustom.cpp | 86 +++++++++++++ 5 files changed, 378 insertions(+), 0 deletions(-)

Eric Seidel (no email)

Comment 2 2009-02-26 14:59:26 PST

Comment on attachment 28040 [details] Add custom V8 bindings for Navigator, Clipboard, Document, and Node, v1. !ec bug!

Dimitri Glazkov (Google)

Comment 3 2009-02-26 15:05:56 PST

Created attachment 28042 [details] Add custom V8 bindings for Navigator, Clipboard, Document, and Node, v2. WebCore/ChangeLog | 17 +++ WebCore/bindings/v8/custom/V8ClipboardCustom.cpp | 141 ++++++++++++++++++++++ WebCore/bindings/v8/custom/V8DocumentCustom.cpp | 86 +++++++++++++ WebCore/bindings/v8/custom/V8NavigatorCustom.cpp | 48 ++++++++ WebCore/bindings/v8/custom/V8NodeCustom.cpp | 86 +++++++++++++ 5 files changed, 378 insertions(+), 0 deletions(-)

Dimitri Glazkov (Google)

Comment 4 2009-02-26 15:15:33 PST

Sorry for my bobo-iness. Fixed now.

Eric Seidel (no email)

Comment 5 2009-02-26 15:19:20 PST

Comment on attachment 28042 [details] Add custom V8 bindings for Navigator, Clipboard, Document, and Node, v2. Ah, the polished turd!

Dimitri Glazkov (Google)

Comment 6 2009-02-26 15:31:20 PST

Landed as http://trac.webkit.org/changeset/41272.

Note You need to log in before you can comment on or make changes to this bug.