Bug 24202 – drawNodeHighlight assumes the highlight is drawn in it's own buffer

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Ojan Vafai]

It first clears the relevant quad and then fills the rect. This won't work for Chromium since we would like to draw the highlight in the same buffer as the page. Instead, we can clip the nested quad from the quad being drawn (e.g. clip the borderQuad from the marginQuad before drawing it). This works for Chromium and Safari as best I can tell.

[Ojan Vafai]

Created attachment 28021 [details]
Have drawNodeHighlight clip instead of clearing. This makes it work for both Safari and Chromium since Chromium draws the inspector highlighting in the same buffer as the page.

 WebCore/ChangeLog                         |   16 ++++++++++++
 WebCore/inspector/InspectorController.cpp |   38 ++++++++++++++++------------
 2 files changed, 38 insertions(+), 16 deletions(-)

[Adam Roben (:aroben)]

Comment on attachment 28021 [details]
Have drawNodeHighlight clip instead of clearing. This makes it work for both Safari and Chromium since Chromium draws the inspector highlighting in the same buffer as the page.

> +        WARNING: NO TEST CASES ADDED OR CHANGED

You should remove this line from your ChangeLog, perhaps replacing it with an explanation (e.g., that there's no change in behavior and it's covered by existing manual Inspector tests).

r=me

[Dimitri Glazkov (Google)]

Has this landed yet?

[Dimitri Glazkov (Google)]

Landed as http://trac.webkit.org/changeset/41258.