Bug 24193 – [GTK] Checkbuttons not activated with space

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Xan Lopez]

Checkbuttons are not activated with space. The reason is that the IM code eats the event, then tries to reintroduce it, and fails when it sees that a checkbutton is not editable. I think the proper fix is simply to not have IM eat events when the focus is on non-editable frames (is frame the right terminology here?).

And no, this does not fix https://bugs.webkit.org/show_bug.cgi?id=18363 :)

[Xan Lopez]

Created attachment 28010 [details]
imevent.patch

commit 1f23190066d5e8740a0e6ab9b26a944a270d4fc5
Author: Xan Lopez <[e-mail]>
Date:   Thu Feb 26 11:44:29 2009 +0200

    2009-02-26  Xan Lopez  <[e-mail]>

            Reviewed by NOBODY (OOPS!).

            https://bugs.webkit.org/show_bug.cgi?id=24193
            [GTK] Checkbuttons not activated with space

            Do not swallow key events with GtkIMContext for non-editable
            frames (FIXME: I don't think frame is the right name here).

            * WebCoreSupport/EditorClientGtk.cpp:
            (WebKit::EditorClient::handleInputMethodKeydown):

[Alexey Proskuryakov]

Comment on attachment 28010 [details]
imevent.patch

>         Do not swallow key events with GtkIMContext for non-editable
>         frames (FIXME: I don't think frame is the right name here).

That's non-editable content.

> +    if (!targetFrame || !targetFrame->editor()->canEdit())
> +        return;

Can targetFrame really be null here?

It's not obvious to me that no input method has useful functions for non-editable content - some Mac IMs have such. So, it may be not quite correct to do an early return here. But it's clear that this code is in need of large refactoring anyway to support input events, and I think that this patch improves the behavior more than it (potentially) regresses it.

>      // TODO: Dispatch IE-compatible text input events for IM events.

We use FIXME, not TODO. Even thought this is old code, it seems appropriate to correct it now.

[Holger Freyther]

Landed in r41249.

[Xan Lopez]

*** Bug 23948 has been marked as a duplicate of this bug. ***