Bug 24184

Summary: WebKit/Qt fails build disabling SVG
Product: WebKit Reporter: Charles Wei <charles.wei>
Component: WebKit QtAssignee: Charles Wei <charles.wei>
Status: RESOLVED FIXED    
Severity: Normal CC: staikos
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
patch to fix the build failure of webkit/qt when SVG disabled staikos: review+

Description Charles Wei 2009-02-25 23:35:38 PST
WebKit for Qt failed build when turning SVG off (change WebCore.pro) .

CSSValueKeywords.in defines 

visiblePainted
visibleStroke
visibleFill

while the application expects them as visiblepainted , visiblestroke and visiblefill respectedly.  While SVG is enabled, this will be converted at build time with perl, while when SVG is disabled,  they are not , and that fails the build;

2nd failure of build failure when SVG is disabled is : 

FontPlatformData::FontPlatformData(float size, bool bold, bool oblique); is declared only when SVG is enabled;  while it's always defined disrearding SVG enabled or not .
Comment 1 Charles Wei 2009-02-26 01:52:45 PST
Created attachment 28011 [details]
patch to fix the build failure of webkit/qt when SVG disabled
Comment 2 Adam Treat 2009-02-26 14:43:09 PST
Landed with r41244.