| Summary: | Make sure return value of dispatch_source_create is memory managed correctly | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||
| Component: | WebKit Misc. | Assignee: | Alex Christensen <achristensen> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, ddkilzer, ews-watchlist, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Alex Christensen
2022-06-21 19:44:46 PDT
Created attachment 460402 [details]
Patch
Created attachment 460406 [details]
Patch
Created attachment 460409 [details]
Patch
Comment on attachment 460409 [details]
Patch
r=me
Comment on attachment 460409 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=460409&action=review > Source/bmalloc/bmalloc/Scavenger.cpp:88 > +#if BPLATFORM(WATCHOS) > + // FIXME: This is concerning. > + static_assert(!__has_feature(objc_arc)); > +#else > + static_assert(__has_feature(objc_arc)); > +#endif I'm not sure why ARC is disabled on watchOS as it's set to be enabled in Configurations/Base.xcconfig. The definition of BENABLE_LIBPAS is dependent on whether the CPU has 64-bit address spaces, and watchOS is the only EWS that is 32-bit and that code was inside #if !BUSE(LIBPAS) Created attachment 460418 [details]
Patch
Committed r295740 (251745@main): <https://commits.webkit.org/251745@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460418 [details]. |