Bug 241836

Summary: Make sure return value of dispatch_source_create is memory managed correctly
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebKit Misc.Assignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ddkilzer, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2022-06-21 19:44:46 PDT
Most of the time we can use smart pointers. This should make the leaks tool happier.
Attachments
Patch (10.77 KB, patch)
2022-06-21 19:46 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (10.82 KB, patch)
2022-06-22 00:16 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (10.82 KB, patch)
2022-06-22 00:41 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (7.71 KB, patch)
2022-06-22 10:17 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2022-06-21 19:44:55 PDT
rdar://95625990
Alex Christensen
Comment 2 2022-06-21 19:46:24 PDT
Created attachment 460402 [details] Patch
Alex Christensen
Comment 3 2022-06-22 00:16:33 PDT
Created attachment 460406 [details] Patch
Alex Christensen
Comment 4 2022-06-22 00:41:41 PDT
Created attachment 460409 [details] Patch
Chris Dumez
Comment 5 2022-06-22 08:42:19 PDT
Comment on attachment 460409 [details] Patch r=me
David Kilzer (:ddkilzer)
Comment 6 2022-06-22 10:05:58 PDT
Comment on attachment 460409 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=460409&action=review > Source/bmalloc/bmalloc/Scavenger.cpp:88 > +#if BPLATFORM(WATCHOS) > + // FIXME: This is concerning. > + static_assert(!__has_feature(objc_arc)); > +#else > + static_assert(__has_feature(objc_arc)); > +#endif I'm not sure why ARC is disabled on watchOS as it's set to be enabled in Configurations/Base.xcconfig.
Alex Christensen
Comment 7 2022-06-22 10:12:13 PDT
The definition of BENABLE_LIBPAS is dependent on whether the CPU has 64-bit address spaces, and watchOS is the only EWS that is 32-bit and that code was inside #if !BUSE(LIBPAS)
Alex Christensen
Comment 8 2022-06-22 10:17:26 PDT
Created attachment 460418 [details] Patch
EWS
Comment 9 2022-06-22 11:35:52 PDT
Committed r295740 (251745@main): <https://commits.webkit.org/251745@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460418 [details].
Radar WebKit Bug Importer
Comment 10 2022-06-22 11:36:12 PDT
<rdar://problem/95709464>
Note You need to log in before you can comment on or make changes to this bug.