Bug 241782

Summary:	Remove Quirk dead code: passive mousewheel event hack for smoothscroll.js
Product:	WebKit	Reporter:	Simon Pieters (:zcorpan) <zcorpan>
Component:	New Bugs	Assignee:	Karl Dubost <karlcow>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	ahmad.saleem792, karlcow, koivisto, simon.fraser, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=207040

Description Simon Pieters (:zcorpan) 2022-06-20 06:09:56 PDT

This is dead code and can be removed:

https://github.com/WebKit/WebKit/blob/dd956d5e74249681ddf904e0bbe401f308b65e0f/Source/WebCore/page/Quirks.cpp#L929-L946

The code above will return something when the event type is 'mousewheel' and event target is window.

See https://github.com/whatwg/dom/issues/1088#issuecomment-1158593953

Comment 1 Radar WebKit Bug Importer 2022-06-27 06:10:13 PDT

<rdar://problem/95972172>

Comment 2 Karl Dubost 2023-11-20 04:57:54 PST

Pull request: https://github.com/WebKit/WebKit/pull/20740

Comment 3 Karl Dubost 2023-11-20 05:02:37 PST

Thanks Ahmad for adding me!
I had missed that bug.

Simon is there a way to test this, to make extra-sure we are not breaking anything else.

Comment 4 EWS 2023-11-20 14:31:15 PST

Committed 270987@main (fc500207b6a8): <https://commits.webkit.org/270987@main>

Reviewed commits have been landed. Closing PR #20740 and removing active labels.

Comment 5 Simon Pieters (:zcorpan) 2023-12-01 03:24:49 PST

There are tests for passive mousewheel in https://wpt.fyi/results/dom/events/non-cancelable-when-passive?label=master&label=experimental&aligned&q=%2Fdom%2Fevents%2Fnon-cancelable-when-passive%2F

Comment 6 Karl Dubost 2023-12-05 00:07:51 PST

Thanks Simon for the link. 

These tests are failing with 

> promise_test: Unhandled rejection with value: object "Error: action_sequence() is not implemented by testdriver-vendor.js"

which is a bug for something else.

Comment 7 Sam Sneddon [:gsnedders] 2023-12-13 02:22:17 PST

(In reply to Karl Dubost from comment #6)
> Thanks Simon for the link. 
> 
> These tests are failing with 
> 
> > promise_test: Unhandled rejection with value: object "Error: action_sequence() is not implemented by testdriver-vendor.js"
> 
> which is a bug for something else.

when running them how? if you just load them in your browser it is expected that testdriver doesn't work, as there's no way for the browser to be controlled externally.