Bug 241713
| Summary: | REGRESSION(r295496): [MacOS] Build terminates with CodeSign error | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Diego Pino <dpino> |
| Component: | New Bugs | Assignee: | Elliott Williams <emw> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, emw, webkit-bug-importer, yurys |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Diego Pino
Since r295496, I'm getting the following error while building WebKit for MacOS:
```
usr/bin/codesign --force --sign - --timestamp\=none --preserve-metadata\=identifier,entitlements,flags --generate-entitlement-der /Users/playwright/webkit/WebKitBuild/Release/InjectedBundleTestWebKitAPI.bundle/Contents/Resources/WebKit.framework
/Users/playwright/webkit/WebKitBuild/Release/InjectedBundleTestWebKitAPI.bundle/Contents/Resources/WebKit.framework: replacing existing signature
/Users/playwright/webkit/WebKitBuild/Release/InjectedBundleTestWebKitAPI.bundle/Contents/Resources/WebKit.framework: unsealed contents…
```
The command I'm using to build is:
```
$ ./Tools/Scripts/build-webkit --release --touch-events --orientation-events
```
Environment is macOS v12.3.1, building with XCode13.2.
Builds work if I build using the new --no-use-workspace flag though.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Elliott Williams
Is build-webkit (without --no-use-workspace) failing reliably in this way? I've seen this before, but it's always been fixed by a rebuild, suggesting some build-time race condition.
Diego Pino
I forgot to mention it always fails on a clean build. Once it has failed, a second attempt to build finishes successfully.
Elliott Williams
(In reply to Diego Pino from comment #2)
> I forgot to mention it always fails on a clean build. Once it has failed, a
> second attempt to build finishes successfully.
Nice. I'll look into this and see if I can reproduce the problem.
Elliott Williams
Pull request: https://github.com/WebKit/WebKit/pull/1699
Elliott Williams
Looks like a simple misconfiguration in one the "Product Dependencies" phases. I'm able to reproduce the problem and fix it with this change.
EWS
Committed r295755 (251760@main): <https://commits.webkit.org/251760@main>
Reviewed commits have been landed. Closing PR #1699 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/95732878>