Bug 241672

Summary: FontCascade members m_useBackslashAsYenSymbol / m_enableKerning / m_requiresShaping don't need to be mutable
Product: WebKit Reporter: Cameron McCormack (:heycam) <heycam>
Component: TextAssignee: Cameron McCormack (:heycam) <heycam>
Status: RESOLVED FIXED    
Severity: Normal CC: mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Cameron McCormack (:heycam)
Reported 2022-06-15 20:07:22 PDT
Thee fields are computed based on the FontDescription. They're only mutable because we also update them in FontCascade::updateFonts(), but that function only updates the FontCascadeFonts pointer, not the FontDescription. So there should be no need to update them at that time.
Attachments
Cameron McCormack (:heycam)
Comment 1 2022-06-15 20:19:36 PDT
EWS
Comment 2 2022-06-16 17:52:16 PDT
Committed r295619 (251624@main): <https://commits.webkit.org/251624@main> Reviewed commits have been landed. Closing PR #1569 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2022-06-16 17:53:16 PDT
Note You need to log in before you can comment on or make changes to this bug.