Summary: | listbox-deselect-scroll and listbox-selection-2 have mac specific code | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Scott Violet <sky> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric, tkent | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Bug Depends on: | 33783, 33989, 33994 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Scott Violet
2009-02-25 09:35:12 PST
My comment should read, 'swap meta/control when run on windows'. Created attachment 27978 [details]
Swaps meta/control when not run on a Mac.
Comment on attachment 27978 [details]
Swaps meta/control when not run on a Mac.
This seems like the wrong way to fix this? Is this test already skipped on Apple's windows build? LayoutTests/platform/win/Skipped
Maybe we already have a cleaner way to make these.
The consensus seems to be to add a new method to event sending controller that simulates a meta click on a mac and control click on windows. I'm planing to change the following eventSender functions: - eventSender.mouseDown([buttonNumber [, modifiers]]) - eventSender.mouseUp([buttonNumber [, modifiers]]) The modifiers parameter is similar to modifiers parameter of evenSender.keyDown(). It's an array of strings. A string can be - a concrete modifier key name; "ctrlKey", "shiftKey", "altKey", or "metaKey", or - a functional modifier name; "addSelectionKey", or "rangeSelectionKey". "addSelectionKey" should be an alias of "metaKey" on Mac, "ctrlKey" on Windows. "rangeSelectionKey" is an alias of "shiftKey". Comments? (In reply to comment #5) > I'm planing to change the following eventSender functions: > - eventSender.mouseDown([buttonNumber [, modifiers]]) > - eventSender.mouseUp([buttonNumber [, modifiers]]) > > The modifiers parameter is similar to modifiers parameter of > evenSender.keyDown(). It's an array of strings. A string can be > - a concrete modifier key name; "ctrlKey", "shiftKey", "altKey", or > "metaKey", or > - a functional modifier name; "addSelectionKey", or "rangeSelectionKey". > "addSelectionKey" should be an alias of "metaKey" on Mac, "ctrlKey" on > Windows. > "rangeSelectionKey" is an alias of "shiftKey". I implemented it for Mac and works fine. I uploaded a patch on Bug#33783. Now both of the tests should work well on non-Mac. |