Bug 24161 – listbox-deselect-scroll and listbox-selection-2 have mac specific code

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Scott Violet]

At a minimum LayoutTests/fast/forms/listbox-deselect-scroll.html should swap meta/control in the events it created. It would be nice if the cell height wasn't hard coded either, but looked up from the option.

[Scott Violet]

My comment should read, 'swap meta/control when run on windows'.

[Scott Violet]

Created attachment 27978 [details]
Swaps meta/control when not run on a Mac.

[Eric Seidel (no email)]

Comment on attachment 27978 [details]
Swaps meta/control when not run on a Mac.

This seems like the wrong way to fix this?  Is this test already skipped on Apple's windows build?  LayoutTests/platform/win/Skipped

Maybe we already have a cleaner way to make these.

[Scott Violet]

The consensus seems to be to add a new method to event sending controller that simulates a meta click on a mac and control click on windows.

[Kent Tamura]

I'm planing to change the following eventSender functions:
  - eventSender.mouseDown([buttonNumber [, modifiers]])
  - eventSender.mouseUp([buttonNumber [, modifiers]])

The modifiers parameter is similar to modifiers parameter of evenSender.keyDown().  It's an array of strings.  A string can be
  - a concrete modifier key name;  "ctrlKey", "shiftKey", "altKey", or "metaKey", or
  - a functional modifier name; "addSelectionKey", or "rangeSelectionKey".
 "addSelectionKey" should be an alias of "metaKey" on Mac, "ctrlKey" on Windows.
 "rangeSelectionKey" is an alias of "shiftKey".

Comments?

[Kent Tamura]

(In reply to comment #5)
> I'm planing to change the following eventSender functions:
>   - eventSender.mouseDown([buttonNumber [, modifiers]])
>   - eventSender.mouseUp([buttonNumber [, modifiers]])
> 
> The modifiers parameter is similar to modifiers parameter of
> evenSender.keyDown().  It's an array of strings.  A string can be
>   - a concrete modifier key name;  "ctrlKey", "shiftKey", "altKey", or
> "metaKey", or
>   - a functional modifier name; "addSelectionKey", or "rangeSelectionKey".
>  "addSelectionKey" should be an alias of "metaKey" on Mac, "ctrlKey" on
> Windows.
>  "rangeSelectionKey" is an alias of "shiftKey".

I implemented it for Mac and works fine. I uploaded a patch on Bug#33783.

[Kent Tamura]

Now both of the tests should work well on non-Mac.