Bug 241515

Summary:	[iOS] Remove figma.com from the simulated mouse events quirk
Product:	WebKit	Reporter:	Wenson Hsieh <wenson_hsieh>
Component:	WebCore Misc.	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	hi, krevis, thorton, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Wenson Hsieh 2022-06-10 10:39:46 PDT

Figma no longer requires this quirked behavior, since they now use pointer events.

Comment 1 Kurt Revis 2022-06-10 11:01:57 PDT

Thank you Wenson!  This will make a lot of people very happy.

Comment 2 Wenson Hsieh 2022-06-10 17:27:31 PDT

(In reply to Kurt Revis from comment #1)
> Thank you Wenson!  This will make a lot of people very happy.

(Us, included!)

One thing to note is that we should also test with iOS 16 beta as well before we remove this quirk, and double check that there aren't any new bugs that might impact Figma's PointerEvent adoption.

Comment 3 Radar WebKit Bug Importer 2022-06-16 09:53:33 PDT

<rdar://problem/95307964>

Comment 4 Kurt Revis 2022-07-13 14:25:06 PDT

Pull request: https://github.com/WebKit/WebKit/pull/2381

Comment 5 Kurt Revis 2022-07-13 14:36:57 PDT

(I'm putting up a PR just to make sure this gets done.)

I've verified that figma.com works fine on iOS 15.5 with site-specific quirks disabled via the web inspector. Our native app also turns off quirks mode and loads the same content, so we're committed to supporting that path.  If any bugs do come up, we're ready and willing to fix them in the site.

If you want to be extra-careful and verify on iOS 16, this blocking bug should now be fixed:
https://bugs.webkit.org/show_bug.cgi?id=242294
(It isn't in any iOS 16 betas yet -- hopefully the next one -- so I can't try it myself.)

Comment 6 Devin Rousso 2022-07-13 14:50:23 PDT

(In reply to Kurt Revis from comment #5)
> (It isn't in any iOS 16 betas yet -- hopefully the next one -- so I can't try it myself.)

FYI, you should be able to generally test without any quirks using the "Site-specific Hacks" checkbox in the Device Settings menu in Web Inspector <https://webkit.org/web-inspector/device-settings/#disable-toggles>.

Note that this will disable *ALL* quirks, so it's not targeted to only this change :)

Comment 7 Kurt Revis 2022-07-13 14:55:45 PDT

Yes, like I said, I tested on iOS 15.5 by doing exactly that.

Comment 8 Devin Rousso 2022-07-13 15:00:06 PDT

(In reply to Kurt Revis from comment #7)
> Yes, like I said, I tested on iOS 15.5 by doing exactly that.

Oh!  My apologies.  I somehow missed that 😅

Comment 9 EWS 2022-07-13 16:48:49 PDT

Committed 252429@main (54155e10cd9e): <https://commits.webkit.org/252429@main>

Reviewed commits have been landed. Closing PR #2381 and removing active labels.