Bug 241509

Summary:	GPUP CGContexts create unattributed Metal resources
Product:	WebKit	Reporter:	Kimmo Kinnunen <kkinnunen>
Component:	WebKit2	Assignee:	Kimmo Kinnunen <kkinnunen>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	jenner, kkinnunen, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Kimmo Kinnunen 2022-06-10 04:51:47 PDT

Add ownership attribution to GPUP CGContext instances

Comment 1 Radar WebKit Bug Importer 2022-06-10 04:54:12 PDT

<rdar://problem/94803367>

Comment 2 Kimmo Kinnunen 2022-06-10 05:03:49 PDT

Pull request: https://github.com/WebKit/WebKit/pull/1443

Comment 3 Kimmo Kinnunen 2022-06-13 00:47:15 PDT

<rdar://93843724>

Comment 4 EWS 2022-06-14 07:54:27 PDT

Committed r295522 (251527@main): <https://commits.webkit.org/251527@main>

Reviewed commits have been landed. Closing PR #1443 and removing active labels.

Comment 5 EWS 2022-06-14 18:13:54 PDT

Committed r295547 (251552@main): <https://commits.webkit.org/251552@main>

Reviewed commits have been landed. Closing PR #1529 and removing active labels.

Comment 6 Robert Jenner 2022-06-14 18:17:13 PDT

https://commits.webkit.org/251527@main created a build failure for Sydney seen here:

https://build-safari.apple.com/#/builders/2550/builds/92032

The failure was: 

./platform/graphics/cocoa/IOSurface.mm:354:70: error: no member named 'taskIdToken' in 'WebCore::ProcessIdentity'
./platform/graphics/cocoa/IOSurface.mm:516:70: error: no member named 'taskIdToken' in 'WebCore::ProcessIdentity'


I have reverted the change the change here:
https://commits.webkit.org/251552@main

Comment 7 Kimmo Kinnunen 2022-06-15 05:47:37 PDT

Pull request: https://github.com/WebKit/WebKit/pull/1533

Comment 8 EWS 2022-06-15 07:03:11 PDT

Committed r295557 (251562@main): <https://commits.webkit.org/251562@main>

Reviewed commits have been landed. Closing PR #1533 and removing active labels.