Bug 241460
| Summary: | REGRESSION(251416@main): Broke GTK... | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Philippe Normand <pnormand> |
| Component: | WebKitGTK | Assignee: | Philippe Normand <philn> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Philippe Normand
In file included from /app/webkit/WebKitBuild/Release/WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-44.cpp:6:
/app/webkit/Source/WebCore/platform/graphics/gtk/SystemFontDatabaseGTK.cpp:57:115: error: non-constant-expression cannot be narrowed from type 'int' to 'float' in initializer list [-Wc++11-narrowing]
SystemFontShorthandInfo result { AtomString::fromLatin1(pango_font_description_get_family(pangoDescription)), size, normalWeightValue() };
^~~~
/app/webkit/Source/WebCore/platform/graphics/gtk/SystemFontDatabaseGTK.cpp:57:115: note: insert an explicit cast to silence this issue
SystemFontShorthandInfo result { AtomString::fromLatin1(pango_font_description_get_family(pangoDescription)), size, normalWeightValue() };
^~~~
static_cast<float>( )
/app/webkit/Source/WebCore/platform/graphics/gtk/SystemFontDatabaseGTK.cpp:36:72: warning: unused parameter 'fontShorthand' [-Wunused-parameter]
auto SystemFontDatabase::platformSystemFontShorthandInfo(FontShorthand fontShorthand) -> SystemFontShorthandInfo
^
1 warning and 1 error generated.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Philippe Normand
Pull request: https://github.com/WebKit/WebKit/pull/1413
EWS
Committed r295417 (251423@main): <https://commits.webkit.org/251423@main>
Reviewed commits have been landed. Closing PR #1413 and removing active labels.