Bug 241437

Summary:

WebGPU::ShaderModule::convertCheckResult() should use std::forward

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

WebGPU

Assignee:

David Kilzer (:ddkilzer) <ddkilzer>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, dino, mmaxfield, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch v1	none

Description David Kilzer (:ddkilzer) 2022-06-08 13:46:27 PDT

WebGPU::ShaderModule::convertCheckResult() should use std::forward.

Found by clang static analyzer:

Source/WebGPU/WebGPU/ShaderModule.mm:125:16: warning: Forwarding reference passed to std::move(), which may unexpectedly cause lvalues to be moved; use std::forward() instead [bugprone-move-forwarding-reference]
        return WTFMove(check);
               ^

Comment 1 Radar WebKit Bug Importer 2022-06-08 13:46:44 PDT

<rdar://problem/94662366>

Comment 2 David Kilzer (:ddkilzer) 2022-06-08 14:05:15 PDT

Created attachment 460102 [details]
Patch v1

Comment 3 David Kilzer (:ddkilzer) 2022-06-08 21:06:54 PDT

Comment on attachment 460102 [details]
Patch v1

Marking as cq+ since enough builds/tests have passed.

Comment 4 EWS 2022-06-08 21:56:06 PDT

Committed r295409 (251415@main): <https://commits.webkit.org/251415@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460102 [details].