Bug 241421

Summary:	[ macOS ][ iOS ] TestWebKitAPI.SOAuthorizationSubFrame.InterceptionError is a flaky timeout
Product:	WebKit	Reporter:	Karl Rackler <rackler>
Component:	New Bugs	Assignee:	Brent Fulgham <bfulgham>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bfulgham, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=239311

Karl Rackler

Reported 2022-06-08 09:33:52 PDT

Description: TestWebKitAPI.SOAuthorizationSubFrame.InterceptionError The first failure that I saw on the dashboard was on 2/21/2022 at 247576@main. The history on the dashboard shows flakiness occurs more frequently on iOS than macOS. History: https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.SOAuthorizationSubFrame.InterceptionError&limit=50000 Log: Timeout TestWebKitAPI.SOAuthorizationSubFrame.InterceptionError ERROR: Could not complete AppSSO: 0 /Volumes/Data/worker/trunk-opensource-ios-simulator-debug-archive/build/OpenSource/Source/WebKit/UIProcess/Cocoa/SOAuthorization/WKSOAuthorizationDelegate.mm(132) : -[WKSOAuthorizationDelegate authorization:didCompleteWithError:]

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2022-06-08 09:34:15 PDT

<rdar://problem/94641397>

Karl Rackler

Comment 2 2022-06-08 13:36:37 PDT

REPRODUCTION STEPS Command: run-api-tests --ios-simulator --debug TestWebKitAPI.SOAuthorizationSubFrame.InterceptionError Result: Test suite failed Timeout TestWebKitAPI.SOAuthorizationSubFrame.InterceptionError ERROR: Could not complete AppSSO: 0 /Volumes/Data/worker/trunk-opensource-ios-simulator-debug-archive/build/OpenSource/Source/WebKit/UIProcess/Cocoa/SOAuthorization/WKSOAuthorizationDelegate.mm(132) : -[WKSOAuthorizationDelegate authorization:didCompleteWithError:]

Brent Fulgham

Comment 3 2022-06-08 13:57:29 PDT

It seems very unlikely that the timeouts are related to the Xcode project change in 247576@main.

Karl Rackler

Comment 4 2022-06-08 16:13:02 PDT

(In reply to Brent Fulgham from comment #3) > It seems very unlikely that the timeouts are related to the Xcode project > change in 247576@main. I agree. I could not find a commit near that range that I could attribute to the timeouts starting.

Brent Fulgham

Comment 5 2022-06-08 16:21:53 PDT

I tried running this on macOS in a loop, but couldn't get the timeout. I'm building for simulator now to see if I can repro.

Brent Fulgham

Comment 6 2022-06-09 15:45:24 PDT

This is the same issue as Bug 239311.

Brent Fulgham

Comment 7 2022-06-09 15:49:53 PDT

Pull request: https://github.com/WebKit/WebKit/pull/1433

Brent Fulgham

Comment 8 2022-06-09 15:52:09 PDT

The proposed change also removes a number of arbitrary 0.5s sleeps, which may help bots move a tiny bit more quickly.

EWS

Comment 9 2022-06-10 10:30:16 PDT

Committed r295456 (251462@main): <https://commits.webkit.org/251462@main> Reviewed commits have been landed. Closing PR #1433 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.