Bug 241347

Summary:	Align WebGL draw call functions
Product:	WebKit	Reporter:	Alexey Knyazev <lexa.knyazev>
Component:	WebGL	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	dino, gman, kbr, kkinnunen, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	219140, 243487

Alexey Knyazev

Reported 2022-06-06 13:59:16 PDT

The following functions should be aligned with regards to validating bound VAOs (if needed), doing implicit clears, and marking the canvas as changed. - WebGLRenderingContextBase::drawElements - WebGLRenderingContextBase::drawArrays - WebGLRenderingContextBase::drawElementsInstanced - WebGLRenderingContextBase::drawArraysInstanced - WebGLMultiDraw::multiDrawArraysWEBGL - WebGLMultiDraw::multiDrawArraysInstancedWEBGL - WebGLMultiDraw::multiDrawElementsWEBGL - WebGLMultiDraw::multiDrawElementsInstancedWEBGL

Attachments
Add attachment proposed patch, testcase, etc.

Kenneth Russell

Comment 1 2022-06-06 14:14:18 PDT

See also similar Chromium-side bug http://crbug.com/1333620 .

Gregg Tavares

Comment 2 2022-06-08 12:37:34 PDT

I think this tests the compositing implications https://github.com/KhronosGroup/WebGL/pull/3430

EWS

Comment 3 2022-06-13 03:17:04 PDT

Committed r295486 (251491@main): <https://commits.webkit.org/251491@main> Reviewed commits have been landed. Closing PR #1452 and removing active labels.

Radar WebKit Bug Importer

Comment 4 2022-06-13 03:18:13 PDT

<rdar://problem/95005496>

Note You need to log in before you can comment on or make changes to this bug.