Bug 241323

Summary: [LFC][FFC] Populate canUseForFlexLayout with unsupported styles and content
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ntim, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[fast-cq]Patch none

zalan
Reported 2022-06-05 21:33:13 PDT
ssia
Attachments
[fast-cq]Patch (2.50 KB, patch)
2022-06-05 21:35 PDT, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2022-06-05 21:35:16 PDT
Created attachment 460044 [details] [fast-cq]Patch
Tim Nguyen (:ntim)
Comment 2 2022-06-06 01:42:44 PDT
Comment on attachment 460044 [details] [fast-cq]Patch View in context: https://bugs.webkit.org/attachment.cgi?id=460044&action=review nice > Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:697 > + if (flexItem.isFloating() || flexItem.isOutOfFlowPositioned()) I'm pretty sure `float` has no effect on flex items. See: data:text/html,<div style="display: flex;"><div style="float: right; width: 200px; height: 200px; background: red"></div></div> or data:text/html,<div style="display: flex;">dsdfdsofjdskfdslvndlcvnfsldjnvdfoskgdfjngfdjnfdljgksdfngfdlg<div style="float: left; width: 200px; height: 200px; background: red"></div></div> I could be wrong though
EWS
Comment 3 2022-06-06 06:08:43 PDT
Committed r295282 (251328@main): <https://commits.webkit.org/251328@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460044 [details].
Radar WebKit Bug Importer
Comment 4 2022-06-06 06:09:13 PDT
<rdar://problem/94432777>
Note You need to log in before you can comment on or make changes to this bug.