Bug 241314 – [LFC][FFC] Take align-self into account when computing flex item's logical height.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[zalan]

ssia

[zalan]

Created attachment 460035 [details]
Patch

[Tim Nguyen (:ntim)]

Comment on attachment 460035 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460035&action=review

> COMMIT_MESSAGE:1
> +[LFC][FFC] Take align-itself into account when computing flex item's logical height. 

nit: align-self not itself :)

[Tim Nguyen (:ntim)]

Comment on attachment 460035 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460035&action=review

> Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:275
> +        auto& flexItemAlignSelf = flexItem.style().alignSelf();
> +        auto alignValue = flexItemAlignSelf.position() != ItemPosition::Auto ? flexItemAlignSelf : flexBoxAlignItems;
> +        switch (alignValue.position()) {

Also, not sure you want to use them, but there's actually helper functions in RenderStyle: https://webkit-search.igalia.com/webkit/rev/572c4442ee7f1dc075302d3b9855403acd5fd651/Source/WebCore/rendering/style/RenderStyle.cpp#272-279 (RenderStyle::resolvedAlignSelf(const RenderStyle* parentStyle, ItemPosition normalValueBehaviour))

[zalan]

(In reply to Tim Nguyen (:ntim) from comment #3)
> Comment on attachment 460035 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=460035&action=review
> 
> > Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:275
> > +        auto& flexItemAlignSelf = flexItem.style().alignSelf();
> > +        auto alignValue = flexItemAlignSelf.position() != ItemPosition::Auto ? flexItemAlignSelf : flexBoxAlignItems;
> > +        switch (alignValue.position()) {
> 
> Also, not sure you want to use them, but there's actually helper functions
> in RenderStyle:
> https://webkit-search.igalia.com/webkit/rev/
> 572c4442ee7f1dc075302d3b9855403acd5fd651/Source/WebCore/rendering/style/
> RenderStyle.cpp#272-279 (RenderStyle::resolvedAlignSelf(const RenderStyle*
> parentStyle, ItemPosition normalValueBehaviour))
We are planning on removing all these from style. They don't belong in there.

[zalan]

Created attachment 460043 [details]
Patch

[EWS]

Committed r295277 (251323@main): <https://commits.webkit.org/251323@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460043 [details].

[Radar WebKit Bug Importer]

<rdar://problem/94418719>