Bug 241313

Summary: [LFC][FFC] column-reverse content should take resolved flex box height into account when computing visual position
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, ntim, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2022-06-04 20:43:56 PDT
ssia
Attachments
Patch (1.90 KB, patch)
2022-06-04 20:51 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (1.89 KB, patch)
2022-06-04 21:35 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2022-06-04 20:51:52 PDT
Created attachment 460034 [details] Patch
Tim Nguyen (:ntim)
Comment 2 2022-06-04 21:07:13 PDT
Comment on attachment 460034 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=460034&action=review > Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:268 > + auto pyhsicalBottom = constraints.logicalTop() + constraints.availableVerticalSpace().value_or(logicalWidth); pyhsical
alan
Comment 3 2022-06-04 21:35:19 PDT
Created attachment 460036 [details] Patch
alan
Comment 4 2022-06-04 21:36:26 PDT
(In reply to Tim Nguyen (:ntim) from comment #2) > Comment on attachment 460034 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=460034&action=review > > > Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:268 > > + auto pyhsicalBottom = constraints.logicalTop() + constraints.availableVerticalSpace().value_or(logicalWidth); > > pyhsical lol, so this made me change it to my preferred term of 'visual".
EWS
Comment 5 2022-06-05 17:04:20 PDT
Committed r295273 (251319@main): <https://commits.webkit.org/251319@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460036 [details].
Radar WebKit Bug Importer
Comment 6 2022-06-05 17:05:13 PDT
<rdar://problem/94410703>
Note You need to log in before you can comment on or make changes to this bug.