Bug 241298
| Summary: | [Xcode] Use workspace builds by default in build-webkit | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Elliott Williams <emw> |
| Component: | Tools / Tests | Assignee: | Elliott Williams <emw> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | emw, kkinnunen, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=241508 | ||
| Bug Depends on: | |||
| Bug Blocks: | 241295, 241863 | ||
Elliott Williams
`build-webkit --use-workspace` has been functional for some time now, and WebKit is free of XCBuild validation warnings. We can make --use-workspace the default, and speed up EWS and other open-source build workflows.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/94375189>
Elliott Williams
Pull request: https://github.com/WebKit/WebKit/pull/1306
Elliott Williams
Pull request: https://github.com/WebKit/WebKit/pull/1421
Kimmo Kinnunen
Hopefully affects bug 241508
Elliott Williams
(In reply to Kimmo Kinnunen from comment #4)
> Hopefully affects bug 241508
It should! I've had a post-commit bot testing workspace builds <https://build.webkit.org/#/builders/463>, which sees 1-2 minute incremental builds in the best case.
EWS
Committed r295496 (251501@main): <https://commits.webkit.org/251501@main>
Reviewed commits have been landed. Closing PR #1306 and removing active labels.
Kimmo Kinnunen
*** Bug 241508 has been marked as a duplicate of this bug. ***