Bug 241168

Summary: Re-import container query WPTs
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, eric.carlson, ews-watchlist, glenn, jer.noble, ntim, philipj, sergio, webkit-bug-importer, youennf, youssefdevelops, y_soliman
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Antti Koivisto 2022-06-01 01:36:52 PDT 
Updates
Comment 1 Antti Koivisto 2022-06-01 01:52:01 PDT 
Created attachment 459922 [details]
Patch
Comment 2 Tim Nguyen (:ntim) 2022-06-01 03:44:01 PDT 
Comment on attachment 459922 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459922&action=review

> COMMIT_MESSAGE:5
> +

Please add the commit hash :)
Comment 3 Antti Koivisto 2022-06-01 03:54:52 PDT 
> Please add the commit hash :)

I don't really see the value.
Comment 4 EWS 2022-06-01 04:30:05 PDT 
Committed r295086 (251181@main): <https://commits.webkit.org/251181@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459922 [details].
Comment 5 Radar WebKit Bug Importer 2022-06-01 04:31:14 PDT 
<rdar://problem/94213819>
Comment 6 Tim Nguyen (:ntim) 2022-06-01 04:48:04 PDT 
(In reply to Antti Koivisto from comment #3)
> > Please add the commit hash :)
> 
> I don't really see the value.

There are many of these import commits, this is pretty much the only way to differentiate them. It also makes it easier when going through blame to know which version of a WPT it is, without having to correlate the date and the upstream commit.

I'm hoping this is automated at some point, but until them, it would be nice to follow this convention.