Bug 241111

Summary: [LFC][FFC] Add support for margin: auto
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
[fast-cq]Patch ews-feeder: commit-queue-

zalan
Reported 2022-05-30 15:14:11 PDT
ssia
Attachments
Patch (11.71 KB, patch)
2022-05-30 16:10 PDT, zalan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (11.71 KB, patch)
2022-05-31 05:33 PDT, zalan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2022-05-30 16:10:14 PDT
Created attachment 459875 [details] Patch
Antti Koivisto
Comment 2 2022-05-30 21:33:37 PDT
Comment on attachment 459875 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459875&action=review > Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:138 > + if (hasAutoMarginStart || hasAutoMarginEnd) > + autoMarginCount += hasAutoMarginStart && hasAutoMarginEnd ? 2 : 1; if (hasAutoMarginStart) ++autoMarginCount; if (hasAutoMarginEnd) ++autoMarginCount; would be easier to parse.
zalan
Comment 3 2022-05-31 05:33:43 PDT
Created attachment 459885 [details] [fast-cq]Patch
EWS
Comment 4 2022-05-31 06:41:10 PDT
Committed r295051 (251146@main): <https://commits.webkit.org/251146@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459885 [details].
Radar WebKit Bug Importer
Comment 5 2022-05-31 06:42:13 PDT
<rdar://problem/94147982>
Note You need to log in before you can comment on or make changes to this bug.