Bug 241105

Summary: Ensure logical properties have skip-builder
Product: WebKit Reporter: Oriol Brufau <obrufau>
Component: CSSAssignee: Oriol Brufau <obrufau>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, joepeck, macpherson, menard, ntim, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Oriol Brufau
Reported 2022-05-30 11:15:30 PDT
Builder::applyProperty resolves logical properties into physical ones. So there is no need to define BuilderCustom methods for them. Thus, most already have skip-builder:true. However, contain-intrinsic-block-size and contain-intrinsic-inline-size don't have that, and then they have some unnecessary methods in BuilderCustom.
Attachments
Patch (6.00 KB, patch)
2022-05-30 11:21 PDT, Oriol Brufau 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oriol Brufau
Comment 1 2022-05-30 11:21:01 PDT
Created attachment 459869 [details] Patch
Tim Nguyen (:ntim)
Comment 2 2022-05-31 04:06:23 PDT
Comment on attachment 459869 [details] Patch Nice cleanup!
EWS
Comment 3 2022-05-31 06:40:02 PDT
Committed r295050 (251145@main): <https://commits.webkit.org/251145@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459869 [details].
Radar WebKit Bug Importer
Comment 4 2022-05-31 06:41:13 PDT
<rdar://problem/94147952>
cathiechen
Comment 5 2022-05-31 06:43:04 PDT
Thanks, Oriol! The patch looks good to me:)
Note You need to log in before you can comment on or make changes to this bug.