Bug 240987
| Summary: | New test: [macOS WK2] fast/images/heic-as-background-image.html is consistently failing | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> |
| Component: | New Bugs | Assignee: | Ryosuke Niwa <rniwa> |
| Status: | REOPENED | ||
| Severity: | Normal | CC: | nmouchtaris, rniwa, webkit-bot-watchers-bugzilla, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari 13 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=240843 https://bugs.webkit.org/show_bug.cgi?id=240990 |
||
Ryan Haddad
images/heic-as-background-image.html has been consisntely failing on macOS WK2 bots since it was added with https://commits.webkit.org/250930@main
Image diff link showing that the test is expecting a green square on white background, but getting a blank white image
https://build.webkit.org/results/Apple-BigSur-Release-WK2-Tests/250994@main%20(9462)/fast/images/heic-as-background-image-diffs.html
https://results.webkit.org/?suite=layout-tests&test=fast/images/heic-as-background-image.html
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/94002031>
Ryan Haddad
These tests were disabled in https://commits.webkit.org/251031@main
Also worth noting, all three tests added/re-enabled with that commit appear to be flakily crashing in VideoToolbox code.. https://build.webkit.org/results/Apple-BigSur-Release-AppleSilicon-WK2-Tests/251011@main%20(8342)/fast/images/animated-heics-draw-crash-log.txt
Nikos Mouchtaris
Filed rdar://94005388 on VideoToolbox to investigate this issue.
Nikos Mouchtaris
Pull request: https://github.com/WebKit/WebKit/pull/2465
EWS
Committed 252517@main (20d56bbc5cbb): <https://commits.webkit.org/252517@main>
Reviewed commits have been landed. Closing PR #2465 and removing active labels.
Nikos Mouchtaris
This pr is just for data collection. This issue hasn't been resolved yet.
Ryosuke Niwa
Re-enabling is good but we probably want failure test expectation so that EWS bots won't get slowed down.
Alexey Proskuryakov
Indeed, crashes appear to be gone, but failing in WK2 remains.
Ryosuke Niwa
Pull request: https://github.com/WebKit/WebKit/pull/2504
EWS
Committed 252559@main (92b4f5717db9): <https://commits.webkit.org/252559@main>
Reviewed commits have been landed. Closing PR #2504 and removing active labels.
Ryosuke Niwa
Once again, the above commit was a test expectation update.
Ryosuke Niwa
(In reply to EWS from comment #10)
> Committed 252559@main (92b4f5717db9):
> <https://commits.webkit.org/252559@main>
>
> Reviewed commits have been landed. Closing PR #2504 and removing active
> labels.
Oops, this is wrong. I need ImageOnlyFailure instead :(
Ryosuke Niwa
Pull request: https://github.com/WebKit/WebKit/pull/2505
EWS
Committed 252562@main (668b1631918d): <https://commits.webkit.org/252562@main>
Reviewed commits have been landed. Closing PR #2505 and removing active labels.
Ryosuke Niwa
Once again, the above commit just updated test expectation.