Bug 240970

Summary: [Interop 2021] WPT upstream expectation change: css/css-flexbox/flex-minimum-height-flex-items-023.html fails
Product: WebKit Reporter: Ryan Reno <rreno>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: bfulgham, karlcow, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: Unspecified   
Bug Depends on: 214292    
Bug Blocks:    

Description Ryan Reno 2022-05-26 12:58:22 PDT
The green square appears to overflow by 25% from expected.

Link to the WPT result:

https://wpt.fyi/results/css/css-flexbox/flex-minimum-height-flex-items-023.html?label=master&label=experimental&aligned

This was fixed in r273955
Comment 1 Radar WebKit Bug Importer 2022-05-26 13:00:14 PDT
<rdar://problem/93990164>
Comment 2 Ryan Reno 2022-05-26 13:07:23 PDT
This may have slipped by our test suite because these flex-minimum-height-flex-items-XXX.html tests are marked [ImageOnlyFailure] in TestExpectations:

023
029
013
015
Comment 3 Ryan Reno 2022-05-26 13:42:23 PDT
After looking a little further into this, it looks like the test changed to match Chrome's behavior in Oct 2021, 9 months after r273955


The commit message for the WPT test (https://github.com/web-platform-tests/wpt/commit/2c83d2e8d545706b565dc6e3dcf77daa77eb5e96) indicates that the behavior of Chrome, FF, and WebKit was out of spec according to the discussion here:

https://github.com/w3c/csswg-drafts/issues/6693

When running Safari against that revision and the test as it existed in 03/2021 it looks like the revision did cause the test to pass but the interpretation of the spec may have changed. I'll look more closely at the csswg discussion.
Comment 4 Karl Dubost 2022-05-26 19:53:29 PDT
Firefox bug about it 
https://bugzilla.mozilla.org/show_bug.cgi?id=1735589