Bug 240964

Summary: [ARM][NEON] Build error after r250982
Product: WebKit Reporter: Pablo Saavedra <psaavedra>
Component: WebCore Misc.Assignee: Pablo Saavedra <psaavedra>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=240777

Pablo Saavedra
Reported 2022-05-26 11:37:17 PDT
Error: ``` /home/bot/yocto-browsers/builds/wandboard-nightly/tmp/work/cortexa9t2hf-neon-imx-poky-linux-gnueabi/wpewebkit/trunk+httpsAUTOINC+bfdd86708b-r0/git/Source/WebCore/platform/graphics/filters/software/FEGaussianBlurSoftwareApplier.cpp:320:29: error: invalid initialization of reference of type 'const Uint8ClampedArray&' {aka 'const JSC::GenericTypedArrayView<JSC::Uint8ClampedAdaptor>&'} from expression of type 'WebCore::PixelBuffer' 320 | boxBlurNEON(*fromBuffer, *toBuffer, kernelSizeY, dyLeft, dyRight, stride, 4, paintSize.height(), paintSize.width()); ``` Error appears after the changes done in r250982. fromBuffer changed Uint8ClampedArray->PixelBuffer: [GPU Process] [Filters] Don't use Uint8ClampedArray in software filter appliers https://bugs.webkit.org/show_bug.cgi?id=240777 rdar://93916935 Reviewed by Simon Fraser. The plan is to allocate the FilterImage buffers differently for GPUProcess. The first step is to hide the underlying memory of PixelBuffer from the software filter appliers. Helpers functions will provide access to Uint8ClampedArray. In future patches different memory allocation will be used by new sub-classes of PixelBuffer.
Attachments
Pablo Saavedra
Comment 1 2022-05-26 11:43:48 PDT
EWS
Comment 2 2022-05-30 08:20:56 PDT
Committed r295029 (251124@main): <https://commits.webkit.org/251124@main> Reviewed commits have been landed. Closing PR #1057 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2022-05-30 08:21:13 PDT
Note You need to log in before you can comment on or make changes to this bug.