Autofocus inputs don't always honor selector input:focus

• Component: Forms
• Status: RESOLVED FIXED

[Anthony Ricaud]

This test by Lachlan Hunt fails. The focus is good but the field should be green.

[Michelangelo De Simone]

*** Bug 31031 has been marked as a duplicate of this bug. ***

[Kaustubh Atrawalkar]

I guess this has been fixed. Can be closed.

[Alexey Proskuryakov]

Should we land this as a regression test?

[Kaustubh Atrawalkar]

Created attachment 114010 [details]
Patch for Adding test case

As this has been already fixed, adding regression test case for the same.

[Kent Tamura]

Comment on attachment 114010 [details]
Patch for Adding test case

View in context: https://bugs.webkit.org/attachment.cgi?id=114010&action=review

> LayoutTests/fast/forms/autofocus-input-css-style-change.html:18
> +if (window.layoutTestController) {
> +    layoutTestController.dumpAsText();
> +}
> +
> +var test = document.getElementById("test");
> +if (document.defaultView.getComputedStyle(test, null).getPropertyValue('background-color') == "rgb(0, 128, 0)")
> +    result.innerHTML = "PASS";

The code style is consistent. The first if has {} for 1-line body, and the second if has no {} for 1-line body.

[Kent Tamura]

(In reply to comment #5)
> The code style is consistent. The first if has {} for 1-line body, and the second if has no {} for 1-line body.

consistent -> inconsistent.

[Alexey Proskuryakov]

Comment on attachment 114010 [details]
Patch for Adding test case

The comment seems minor enough to land as is, marking cq+.

[WebKit Review Bot]

Comment on attachment 114010 [details]
Patch for Adding test case

Clearing flags on attachment: 114010

Committed r99582: <http://trac.webkit.org/changeset/99582>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Kaustubh Atrawalkar]

Thanks for the review Kent & Alexey.