Bug 240841
| Summary: | REGRESSION (r294610): [ macOS wk1 ] scroll-into-view-and-show-validation-message.html and textarea-scrolled-endline-caret.html are flaky | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Karl Rackler <rackler> |
| Component: | New Bugs | Assignee: | Karl Rackler <rackler> |
| Status: | REOPENED | ||
| Severity: | Normal | CC: | brandonstewart, gnavamarino, rniwa, svillar, webkit-bot-watchers-bugzilla, webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=224471 | ||
Karl Rackler
Description:
fast/forms/scroll-into-view-and-show-validation-message.html
fast/forms/textarea-scrolled-endline-caret.html
The first failure I saw on the dashboard was on 5/19/2022 at r294525. r294523 modified updateLayout() via HTMLTextAreaElement::childrenChanged, caused the tests to fail and others and reverted at r294550. The tests begin passing consistently again until r294610 and then begin flaky failing.
REPRODUCTION STEPS
I can reproduce this on r294610, but unable to reproduce it on r294609 or earlier.
Command:
run-webkit-tests --debug -1 --root 294610-debug --exit-after-n-failures 1 --exit-after-n-crashes-or-timeouts 1 --iterations 250 -f --no-retry fast/forms/scroll-into-view-and-show-validation-message.html
Result:
Unexpected flakiness: text-only failures (1)
fast/forms/scroll-into-view-and-show-validation-message.html [ Pass Failure ]
History:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=fast%2Fforms%2Fstate-restore-to-non-edited-controls.html&test=fast%2Fforms%2Ftextarea-scrolled-endline-caret.html&platform=mac&flavor=wk1&limit=50000
Diff:
1. fast/forms/scroll-into-view-and-show-validation-message.html
--- /Volumes/Data/worker/Apple-Monterey-Debug-AppleSilicon-WK1-Tests/build/layout-test-results/fast/forms/scroll-into-view-and-show-validation-message-expected.txt
+++ /Volumes/Data/worker/Apple-Monterey-Debug-AppleSilicon-WK1-Tests/build/layout-test-results/fast/forms/scroll-into-view-and-show-validation-message-actual.txt
@@ -3,8 +3,10 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS message is "Fill out this field"
+FAIL Unexpected message:
+FAIL message should be Fill out this field. Was .
PASS successfullyParsed is true
+Some tests failed.
TEST COMPLETE
Submit
2. fast/forms/textarea-scrolled-endline-caret.html
--- /Volumes/Data/worker/Apple-Monterey-Debug-WK1-Tests/build/layout-test-results/fast/forms/textarea-scrolled-endline-caret-expected.txt
+++ /Volumes/Data/worker/Apple-Monterey-Debug-WK1-Tests/build/layout-test-results/fast/forms/textarea-scrolled-endline-caret-actual.txt
@@ -1,2 +1,2 @@
-Test Succeeded
+Test Failed: caret is at 1
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/93794351>
Karl Rackler
I have marked these tests as a flaky failure while this issue is investigated.
Karl Rackler
Pull request: https://github.com/WebKit/WebKit/pull/954
EWS
Test gardening commit r294702 (250899@main): <https://commits.webkit.org/250899@main>
Reviewed commits have been landed. Closing PR #954 and removing active labels.
Ryan Haddad
There was a fix for fast/forms/textarea-scrolled-endline-caret.html committed in https://commits.webkit.org/250998@main.
Alexey Proskuryakov
See also: rdar://93794351
Ryan Haddad
Keeping open since only one test was fixed.