Bug 240831
| Summary: | WebKit projects should be consistent about whether `WK_USE_OVERRIDE_FRAMEWORKS_DIR` is enabled for Mac Catalyst | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Elliott Williams <emw> |
| Component: | Tools / Tests | Assignee: | Elliott Williams <emw> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, david_quesada, thorton, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Elliott Williams
Catalyst builds install content to /System/iOSSupport by setting WK_ALTERNATE_FRAMEWORKS_DIR. In some projects, WK_ALTERNATE_FRAMEWORKS_DIR affects WK_OVERRIDE_FRAMEWORKS_DIR, but since r230958, others keep the two build settings separate.
There is value in logically separating alternate and override directories, as it makes it easier to distinguish between system-installed builds such as Mac Catalyst, and self-contained builds such as Safari Technology Preview. I suggest we resolve the inconsistency by using r230958's logic everywhere.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/93786889>
Elliott Williams
Pull request: https://github.com/WebKit/WebKit/pull/951
EWS
Committed r294767 (250932@main): <https://commits.webkit.org/250932@main>
Reviewed commits have been landed. Closing PR #951 and removing active labels.