Summary: | [CMake][Visual Studio] PrivateHeaders/JavaScriptCore/InspectorProtocolObjects.h isn't regenerated in incremental builds | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||
Component: | CMake | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | annulen, don.olmstead, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, msaboff, ryuan.choi, saam, sergio, tzagallo, yurys | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Fujii Hironori
2022-05-17 14:33:00 PDT
Created attachment 459517 [details]
Patch
Looking at Source/JavaScriptCore/CMakeLists.txt the dependency chain looks correct to me but I see that there are two entries like this: ``` MAIN_DEPENDENCY ${JavaScriptCore_DERIVED_SOURCES_DIR}/CombinedDomains.json ``` one is for C++ bindings and the other is for inspector UI. At the same time Cmake documentation for MAIN_DEPENDENCY says[1]: ``` MAIN_DEPENDENCY <...> Each source file may have at most one command specifying it as its main dependency. <...> ``` I wonder if that causes InspectorProtocolObjects.h to not be properly recompiled. Fujii, what do you think? [1] https://cmake.org/cmake/help/latest/command/add_custom_command.html Do you mean a change like this? https://gist.github.com/fujii/af58b4f46bbaac0aa91c072072a2a975 This change doesn't fix this bug. (In reply to Fujii Hironori from comment #3) > Do you mean a change like this? > https://gist.github.com/fujii/af58b4f46bbaac0aa91c072072a2a975 > > This change doesn't fix this bug. Yes, just my guess. Committed r294462 (250724@main): <https://commits.webkit.org/250724@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459517 [details]. |