Bug 240529
| Summary: | git webkit setup ignores configured editor | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | jbedard, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 239082 | ||
Alexey Proskuryakov
I chose default when running git webkit setup, and I have this in my environment:
export SVN_EDITOR=commit-log-editor
export SVN_LOG_EDITOR="/usr/local/bin/bbedit --view-top --wait --resume"
And yet I'm getting vi invoked for writing the commit message. I would expect my environment to be respected for "default".
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/93521972>
Jonathan Bedard
Pull request: https://github.com/WebKit/WebKit/pull/757
Jonathan Bedard
Pull request: https://github.com/WebKit/WebKit/pull/758
EWS
Committed r294480 (250739@main): <https://commits.webkit.org/250739@main>
Reviewed commits have been landed. Closing PR #757 and removing active labels.
EWS
Committed r294489 (250748@main): <https://commits.webkit.org/250748@main>
Reviewed commits have been landed. Closing PR #758 and removing active labels.