Bug 240484
| Summary: | [css-ui] Unexpose remaining media-* appearance values | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Nguyen (:ntim) <ntim> |
| Component: | CSS | Assignee: | Tim Nguyen (:ntim) <ntim> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | akeerthi, webkit-bug-importer, zsun |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Tim Nguyen (:ntim)
2 possibilities:
- Remove them entirely if unimplemented/no-op
- guard them behind a setting or useSystemAppearance if used by Apple apps
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/93376288>
Tim Nguyen (:ntim)
Here's the list:
media-controls-dark-bar-background
media-controls-light-bar-background
media-fullscreen-volume-slider
media-fullscreen-volume-slider-thumb
media-play-button
media-slider
media-sliderthumb
media-volume-slider
media-volume-slider-mute-button
media-volume-sliderthumb
Tim Nguyen (:ntim)
I'm removing media-controls-dark-bar-background & media-controls-light-bar-background entirely in bug 240756
Tim Nguyen (:ntim)
Bug 240760 will remove media-play-button and media-volume-slider-mute.
Tim Nguyen (:ntim)
I think the remainder can be made UA sheet-only or/and useSystemAppearance-only.
Tim Nguyen (:ntim)
Pull request: https://github.com/WebKit/WebKit/pull/924
EWS
Committed r294677 (250886@main): <https://commits.webkit.org/250886@main>
Reviewed commits have been landed. Closing PR #924 and removing active labels.