Bug 240447
| Summary: | [css-ui] Unexpose attachment and borderless-attachment appearance values | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Nguyen (:ntim) <ntim> |
| Component: | CSS | Assignee: | Tim Nguyen (:ntim) <ntim> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | akeerthi, thorton, webkit-bug-importer, zsun |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Tim Nguyen (:ntim)
borderless-attachment should be restricted behind useSystemAppearance. Although I wonder if we could make this work through appearance: auto + borderless attribute, so we can stop exposing the CSS value altogether, though that would require consumers of <attachment> + appearance: borderless-attachment to change to <attachment borderless>.
attachment is implemented via appearance: auto, so we shouldn't need to keep the CSS value around.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/93331974>
Tim Horton
> behind useSystemAppearance
Please use attachmentElementEnabled instead.
Tim Nguyen (:ntim)
Pull Request: https://github.com/WebKit/WebKit/pull/649
EWS
Committed r294267 (250615@main): <https://commits.webkit.org/250615@main>
Reviewed commits have been landed. Closing PR #649 and removing active labels.