Bug 240416

Summary: Template TextBoxPainter on line layout path
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: basuke, bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, mcatanzaro, mmaxfield, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
patch
none
Patch none

Antti Koivisto
Reported 2022-05-14 02:18:28 PDT
Painting currently goes via line layout path agnostic iterator. This is inefficient since we always know what sort of layout we are painting.
Attachments
Patch (48.43 KB, patch)
2022-05-14 02:22 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (43.79 KB, patch)
2022-05-14 06:19 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (44.69 KB, patch)
2022-05-17 07:54 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2022-05-14 02:22:45 PDT
Created attachment 459348 [details] Patch
Antti Koivisto
Comment 2 2022-05-14 06:19:47 PDT
Created attachment 459353 [details] patch
EWS
Comment 3 2022-05-14 10:52:23 PDT
Committed r294204 (250565@main): <https://commits.webkit.org/250565@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459353 [details].
Radar WebKit Bug Importer
Comment 4 2022-05-14 10:53:15 PDT
<rdar://problem/93293276>
Michael Catanzaro
Comment 5 2022-05-16 14:38:01 PDT
Re-opening for pull request https://github.com/WebKit/WebKit/pull/650
EWS
Comment 6 2022-05-16 14:42:20 PDT
Committed r294262 (250610@main): <https://commits.webkit.org/250610@main> Reviewed commits have been landed. Closing PR #650 and removing active labels.
Simon Fraser (smfr)
Comment 7 2022-05-16 16:37:52 PDT
Caused text rendering bugs: bug 240491.
Antti Koivisto
Comment 8 2022-05-17 07:54:47 PDT
Created attachment 459498 [details] Patch
EWS
Comment 9 2022-05-17 07:58:28 PDT
Unable to find any modified ChangeLog in Attachment 459498 [details]
Antti Koivisto
Comment 10 2022-05-17 08:14:43 PDT
Pull request: https://github.com/WebKit/WebKit/pull/675
EWS
Comment 11 2022-05-17 23:28:05 PDT
Committed r294383 (250680@main): <https://commits.webkit.org/250680@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459498 [details].
Michael Catanzaro
Comment 12 2022-05-18 11:43:23 PDT
(In reply to Antti Koivisto from comment #10) > Pull request: https://github.com/WebKit/WebKit/pull/675 You landed the same build failure again. Out of curiosity, is there any plan to make this non-experimental? I wonder if having a build flag is really worth it?
Michael Catanzaro
Comment 13 2022-05-18 11:58:58 PDT
(Remember that ENABLE(EXPERIMENTAL_FEATURES) is enabled on EWS, and ENABLE(LAYOUT_FORMATTING_CONTEXT) is tied to that. So all the EWS will pass, but the releases will still be broken. Got to be careful....)
alan
Comment 14 2022-05-18 12:02:05 PDT
(In reply to Michael Catanzaro from comment #12) > (In reply to Antti Koivisto from comment #10) > > Pull request: https://github.com/WebKit/WebKit/pull/675 > > You landed the same build failure again. > > Out of curiosity, is there any plan to make this non-experimental? I wonder > if having a build flag is really worth it? Yeah, the build flag makes very little sense at this point. We should get rid of it.
Antti Koivisto
Comment 15 2022-05-18 12:18:40 PDT
(In reply to Michael Catanzaro from comment #13) > (Remember that ENABLE(EXPERIMENTAL_FEATURES) is enabled on EWS, and > ENABLE(LAYOUT_FORMATTING_CONTEXT) is tied to that. So all the EWS will pass, > but the releases will still be broken. Got to be careful....) All platforms should have LAYOUT_FORMATTING_CONTEXT enabled unconditionally. It is on Cocoa platforms.
Antti Koivisto
Comment 16 2022-05-18 12:19:06 PDT
(and the flag should be removed)
Michael Catanzaro
Comment 17 2022-05-18 12:43:41 PDT
(In reply to Antti Koivisto from comment #15) > All platforms should have LAYOUT_FORMATTING_CONTEXT enabled unconditionally. > It is on Cocoa platforms. I see it's off at runtime on all platforms (WTF/Scripts/Preferences/WebPreferencesInternal.yaml). Removing the build flag makes sense to me regardless.
Michael Catanzaro
Comment 18 2022-05-18 12:45:26 PDT
Re-opening for pull request https://github.com/WebKit/WebKit/pull/741
EWS
Comment 19 2022-05-18 12:49:13 PDT
Committed r294426 (250708@main): <https://commits.webkit.org/250708@main> Reviewed commits have been landed. Closing PR #741 and removing active labels.
Antti Koivisto
Comment 20 2022-05-18 12:55:01 PDT
> I see it's off at runtime on all platforms > (WTF/Scripts/Preferences/WebPreferencesInternal.yaml). InlineFormattingContextIntegrationEnabled is behind this conditional and is enabled by default.
Basuke Suzuki
Comment 21 2022-05-18 14:26:52 PDT
*** Bug 240590 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.