Bug 24039 – Separate gtk unit tests

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Christian Dywan]

The few gtk specific tests we have at this point are all contained in one source file. I'd like to split up the tests per feature and keep that in mind for the future.

For instance "web view", "web frame", "back forward list" would seem like a start.

On a related matter, what about running these tests in "make check"?

[Jan Alonzo]

Created attachment 28395 [details]
Separate the tests

This patch also includes the build support needed to build the separate tests.

[Holger Freyther]

Could you explain the reasoning behind creating multiple programs. The only benefit is that one run of a test is not influencing other parts. The downsides are runtime overhead to start the app, repeated boilerplate code, people driving the tests need to know the multiple binary names...

I think the different files/areas should be separate GTestSuite's.

[Christian Dywan]

(In reply to comment #2)
> Could you explain the reasoning behind creating multiple programs. The only
> benefit is that one run of a test is not influencing other parts. The downsides
> are runtime overhead to start the app, repeated boilerplate code, people
> driving the tests need to know the multiple binary names...
> 
> I think the different files/areas should be separate GTestSuite's.

Well, the main reason is modularity which makes it easy to maintain, run particular tests independently, add new tests, avoid having to edit a file that is several megabytes large...

The overhead isn't really noticible. Arguably WebCore should live in a single file because that decreases linking overhead, what do you think? ;)

[Holger Freyther]

It is not about the linking overhead. But think of automatic execution of the test executables, collecting the results, generating coverage data... having a single executable makes it a lot more easy to have a stable test setup.

[Holger Freyther]

Comment on attachment 28395 [details]
Separate the tests


> [phone]  Jan Michael Alonzo  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Separate gtk unit tests
> +        https://bugs.webkit.org/show_bug.cgi?id=24039

Could you please describe the reasoning of the split up here?

and please use svn cp to copy the file when landing.

[Jan Alonzo]

(In reply to comment #5)
> (From update of attachment 28395 [details] [review])
> 
> > [phone]  Jan Michael Alonzo  <[e-mail]>
> > +
> > +        Reviewed by NOBODY (OOPS!).
> > +
> > +        Separate gtk unit tests
> > +        https://bugs.webkit.org/show_bug.cgi?id=24039
> 
> Could you please describe the reasoning of the split up here?
> 
> and please use svn cp to copy the file when landing.
> 

Thanks. Landed in r41864