Bug 240343
| Summary: | readonly attribute should only apply on certain input types | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Nguyen (:ntim) <ntim> |
| Component: | Forms | Assignee: | Tim Nguyen (:ntim) <ntim> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cdumez, webkit-bug-importer, wenson_hsieh, zsun |
| Priority: | P2 | Keywords: | InRadar, WPTImpact |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=239302 | ||
| Bug Depends on: | |||
| Bug Blocks: | 237192 | ||
Tim Nguyen (:ntim)
See the readonly row on: https://html.spec.whatwg.org/multipage/input.html#do-not-apply
Only applies to text only input types + <textarea>
Text,
Search
URL,
Telephone
Email
Password
Date,
Month,
Week,
Time
Local Date and Time
Number
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/93173726>
Tim Nguyen (:ntim)
I'll take this. There's quite a bit that could be improved here.
Tim Nguyen (:ntim)
I won't be able to look into this soon, feel free to take this over.
Seems like we have a supportsReadOnly() function on InputType, which should be helpful.
I would either change the m_isReadOnly bit (which needs to be updated on type change too) or the isDisabledOrReadOnly function. Shouldn't be too hard, just a bit tedious.
Tim Nguyen (:ntim)
Pull request: https://github.com/WebKit/WebKit/pull/3115
EWS
Committed 253321@main (af43ca312063): <https://commits.webkit.org/253321@main>
Reviewed commits have been landed. Closing PR #3115 and removing active labels.