Bug 240301

Summary:

Resync web-platform-tests/html/semantics/forms tests from upstream

Product:

WebKit

Reporter:

zsun

Component:

Forms

Assignee:

zsun

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, clopez, ews-watchlist, ntim, webkit-bug-importer, wenson_hsieh, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

240302

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
[fast-cq] Patch	none

zsun

Reported 2022-05-11 03:02:29 PDT

resync

Attachments
Patch (178.08 KB, patch) 2022-05-11 03:09 PDT, zsun	no flags	Details Formatted Diff Diff
Patch (247.20 KB, patch) 2022-05-11 06:41 PDT, zsun	no flags	Details Formatted Diff Diff
Patch (321.90 KB, patch) 2022-05-12 02:50 PDT, zsun	no flags	Details Formatted Diff Diff
Patch (319.38 KB, patch) 2022-05-12 03:25 PDT, zsun	no flags	Details Formatted Diff Diff
[fast-cq] Patch (322.04 KB, patch) 2022-05-12 04:39 PDT, zsun	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

zsun

Comment 1 2022-05-11 03:09:01 PDT

Created attachment 459153 [details] Patch

zsun

Comment 2 2022-05-11 06:41:47 PDT

Created attachment 459162 [details] Patch

Tim Nguyen (:ntim)

Comment 3 2022-05-11 18:58:58 PDT

Comment on attachment 459162 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459162&action=review > LayoutTests/imported/w3c/ChangeLog:7 > + It would be nice to have upstream commit hash/link in the changelogs descriptions

zsun

Comment 4 2022-05-12 02:50:08 PDT

Created attachment 459217 [details] Patch

zsun

Comment 5 2022-05-12 03:25:46 PDT

Created attachment 459218 [details] Patch

zsun

Comment 6 2022-05-12 04:39:52 PDT

Created attachment 459222 [details] [fast-cq] Patch

Tim Nguyen (:ntim)

Comment 7 2022-05-12 06:06:34 PDT

Comment on attachment 459222 [details] [fast-cq] Patch Thanks! It would be nice to simplify the selection-not-application-expected.txt expectations (every platform one has one, despite some similarities), but it could be done in other patch. Ideally mac-wk2 expectations would be default, and we would delete any identical expectation files.

zsun

Comment 8 2022-05-12 07:18:57 PDT

(In reply to Tim Nguyen (:ntim) from comment #7) > Comment on attachment 459222 [details] > Patch > > Thanks! > > It would be nice to simplify the selection-not-application-expected.txt > expectations (every platform one has one, despite some similarities), but it > could be done in other patch. Ideally mac-wk2 expectations would be default, > and we would delete any identical expectation files. Thanks! There are a few other test expectations might also need this simplification. I filed bug 240344 and will do them all together there.

Tim Nguyen (:ntim)

Comment 9 2022-05-12 07:46:16 PDT

(In reply to zsun from comment #8) > (In reply to Tim Nguyen (:ntim) from comment #7) > > Comment on attachment 459222 [details] > > Patch > > > > Thanks! > > > > It would be nice to simplify the selection-not-application-expected.txt > > expectations (every platform one has one, despite some similarities), but it > > could be done in other patch. Ideally mac-wk2 expectations would be default, > > and we would delete any identical expectation files. > > Thanks! There are a few other test expectations might also need this > simplification. I filed bug 240344 and will do them all together there. Sounds good, thanks!

Radar WebKit Bug Importer

Comment 10 2022-05-12 07:52:42 PDT

<rdar://problem/93174051>

EWS

Comment 11 2022-05-13 02:27:00 PDT

Committed r294153 (250523@main): <https://commits.webkit.org/250523@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459222 [details].

Note You need to log in before you can comment on or make changes to this bug.