Summary: | Resync web-platform-tests/html/semantics/forms tests from upstream | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zsun | ||||||||||||
Component: | Forms | Assignee: | zsun | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | cdumez, clopez, ews-watchlist, ntim, webkit-bug-importer, wenson_hsieh, youennf | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 240302 | ||||||||||||||
Attachments: |
|
Description
zsun
2022-05-11 03:02:29 PDT
Created attachment 459153 [details]
Patch
Created attachment 459162 [details]
Patch
Comment on attachment 459162 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459162&action=review > LayoutTests/imported/w3c/ChangeLog:7 > + It would be nice to have upstream commit hash/link in the changelogs descriptions Created attachment 459217 [details]
Patch
Created attachment 459218 [details]
Patch
Created attachment 459222 [details]
[fast-cq] Patch
Comment on attachment 459222 [details]
[fast-cq] Patch
Thanks!
It would be nice to simplify the selection-not-application-expected.txt expectations (every platform one has one, despite some similarities), but it could be done in other patch. Ideally mac-wk2 expectations would be default, and we would delete any identical expectation files.
(In reply to Tim Nguyen (:ntim) from comment #7) > Comment on attachment 459222 [details] > Patch > > Thanks! > > It would be nice to simplify the selection-not-application-expected.txt > expectations (every platform one has one, despite some similarities), but it > could be done in other patch. Ideally mac-wk2 expectations would be default, > and we would delete any identical expectation files. Thanks! There are a few other test expectations might also need this simplification. I filed bug 240344 and will do them all together there. (In reply to zsun from comment #8) > (In reply to Tim Nguyen (:ntim) from comment #7) > > Comment on attachment 459222 [details] > > Patch > > > > Thanks! > > > > It would be nice to simplify the selection-not-application-expected.txt > > expectations (every platform one has one, despite some similarities), but it > > could be done in other patch. Ideally mac-wk2 expectations would be default, > > and we would delete any identical expectation files. > > Thanks! There are a few other test expectations might also need this > simplification. I filed bug 240344 and will do them all together there. Sounds good, thanks! Committed r294153 (250523@main): <https://commits.webkit.org/250523@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459222 [details]. |